-
Notifications
You must be signed in to change notification settings - Fork 2
0.1.7 #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.1.7 #281
Conversation
* Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review
* Eslint fixes * Prettierrc fixes * Updated changelog
* Added min/max toasts * Update changelog * Replace icon
* Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]>
* Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review
* Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review
* Fixed copy button * Upgraded version
* 0.1.5 (#275) * Refactored sign transactions panel internal components (#267) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review * Eslint and prettierrc fixes (#270) * Eslint fixes * Prettierrc fixes * Updated changelog * Added minimize/maximize toasts (#272) * Added min/max toasts * Update changelog * Replace icon * Fixed trimmed address not showing in address-table (#273) * Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]> * Refactored side panel components (#271) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review * Refactored transaction list item (#274) * Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review * Upgraded version --------- Co-authored-by: Gavrila Andrei <[email protected]> * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]>
* Updated package version * Updated changelog * Updated lockfile
Summary of ChangesHello @iuliacimpeanu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces version "0.1.7" of the project, primarily to address and resolve a compatibility issue related to the "@stencil/core" dependency. The update ensures the project functions correctly with the specified version of Stencil, maintaining stability and preventing potential conflicts. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the package version to 0.1.7 and pins the @stencil/core dependency to version 4.38.1. This is a positive change that improves build stability. I've added a comment suggesting to also pin other dependencies that use loose version ranges to prevent potential future issues. Overall, the changes are good and contribute to better dependency management.
* 0.1.7 (#281) * Refactored sign transactions panel internal components (#267) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review * Eslint and prettierrc fixes (#270) * Eslint fixes * Prettierrc fixes * Updated changelog * Added minimize/maximize toasts (#272) * Added min/max toasts * Update changelog * Replace icon * Fixed trimmed address not showing in address-table (#273) * Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]> * Refactored side panel components (#271) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review * Refactored transaction list item (#274) * Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review * Upgraded version * Fixed copy button (#276) * Fixed copy button * Upgraded version * Sync development with main (#278) * 0.1.5 (#275) * Refactored sign transactions panel internal components (#267) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review * Eslint and prettierrc fixes (#270) * Eslint fixes * Prettierrc fixes * Updated changelog * Added minimize/maximize toasts (#272) * Added min/max toasts * Update changelog * Replace icon * Fixed trimmed address not showing in address-table (#273) * Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]> * Refactored side panel components (#271) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review * Refactored transaction list item (#274) * Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review * Upgraded version --------- Co-authored-by: Gavrila Andrei <[email protected]> * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]> * Fixed compatibility issue on stencil/core (#279) * Updated package version * Updated changelog * Updated lockfile * Upgraded version --------- Co-authored-by: Gavrila Andrei <[email protected]> Co-authored-by: Tudor Morar <[email protected]> * v0.1.8 (#283) - fix SidePanel WalletConnect issues - (temp) fix sdk-dapp 5.5.1 breaking changes - update publish script - pnpm test fix * Add provider selection handling to unlock panel - Subscribed to SELECT_PROVIDER event to handle provider selection. - Implemented handleProviderSelection method to initiate login with the selected provider. - Updated unsubscribe functions to include the new subscription. * Update CHANGELOG * Update CHANGELOG * Update version --------- Co-authored-by: Iulia Cimpeanu <[email protected]> Co-authored-by: Gavrila Andrei <[email protected]> Co-authored-by: Radu Mojic <[email protected]>
* Refactored sign transactions panel internal components (#267) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review * Eslint and prettierrc fixes (#270) * Eslint fixes * Prettierrc fixes * Updated changelog * Added minimize/maximize toasts (#272) * Added min/max toasts * Update changelog * Replace icon * Fixed trimmed address not showing in address-table (#273) * Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]> * Refactored side panel components (#271) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review * Refactored transaction list item (#274) * Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review * Upgraded version * Fixed copy button (#276) * Fixed copy button * Upgraded version * Sync development with main (#278) * 0.1.5 (#275) * Refactored sign transactions panel internal components (#267) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review * Eslint and prettierrc fixes (#270) * Eslint fixes * Prettierrc fixes * Updated changelog * Added minimize/maximize toasts (#272) * Added min/max toasts * Update changelog * Replace icon * Fixed trimmed address not showing in address-table (#273) * Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]> * Refactored side panel components (#271) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review * Refactored transaction list item (#274) * Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review * Upgraded version --------- Co-authored-by: Gavrila Andrei <[email protected]> * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]> * Fixed compatibility issue on stencil/core (#279) * Updated package version * Updated changelog * Updated lockfile * Upgraded version * Refactored pagination component (#282) * Refactored pagination comp * Refactored pagination ellipsis * Work on pagination * Refactor components * Work on pagination * Fixed pagination story * Move pagination to address-table * Update CHANGELOG * Try fix tests * Remove log * Remove unused contentclass * Remove logs * Minor edits * /gemini review --------- Co-authored-by: Tudor Morar <[email protected]> * Select provider (#285) * 0.1.7 (#281) * Refactored sign transactions panel internal components (#267) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review * Eslint and prettierrc fixes (#270) * Eslint fixes * Prettierrc fixes * Updated changelog * Added minimize/maximize toasts (#272) * Added min/max toasts * Update changelog * Replace icon * Fixed trimmed address not showing in address-table (#273) * Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]> * Refactored side panel components (#271) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review * Refactored transaction list item (#274) * Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review * Upgraded version * Fixed copy button (#276) * Fixed copy button * Upgraded version * Sync development with main (#278) * 0.1.5 (#275) * Refactored sign transactions panel internal components (#267) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review * Eslint and prettierrc fixes (#270) * Eslint fixes * Prettierrc fixes * Updated changelog * Added minimize/maximize toasts (#272) * Added min/max toasts * Update changelog * Replace icon * Fixed trimmed address not showing in address-table (#273) * Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]> * Refactored side panel components (#271) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review * Refactored transaction list item (#274) * Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review * Upgraded version --------- Co-authored-by: Gavrila Andrei <[email protected]> * Updated changelog --------- Co-authored-by: Gavrila Andrei <[email protected]> * Fixed compatibility issue on stencil/core (#279) * Updated package version * Updated changelog * Updated lockfile * Upgraded version --------- Co-authored-by: Gavrila Andrei <[email protected]> Co-authored-by: Tudor Morar <[email protected]> * v0.1.8 (#283) - fix SidePanel WalletConnect issues - (temp) fix sdk-dapp 5.5.1 breaking changes - update publish script - pnpm test fix * Add provider selection handling to unlock panel - Subscribed to SELECT_PROVIDER event to handle provider selection. - Implemented handleProviderSelection method to initiate login with the selected provider. - Updated unsubscribe functions to include the new subscription. * Update CHANGELOG * Update CHANGELOG * Update version --------- Co-authored-by: Iulia Cimpeanu <[email protected]> Co-authored-by: Gavrila Andrei <[email protected]> Co-authored-by: Radu Mojic <[email protected]> * Remove unused file --------- Co-authored-by: Iulia Cimpeanu <[email protected]> Co-authored-by: Gavrila Andrei <[email protected]> Co-authored-by: Iulia Cimpeanu <[email protected]> Co-authored-by: Radu Mojic <[email protected]>
No description provided.